fix: hydrate channel instance from thread response #1354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Thread
instance created an unitizedChannel
instance for the parent channel. The idea was that when the thread is rendered, it will be rendered inside theChannel
component which will take care of initializing the instance.However, it makes sense to expect at least some data in this channel instance: its name and members. This data is available in the thread response which is used to construct a
Thread
instance.So now we try to hydrate the channel instance with whatever data we have. This fixes at least one known bug: channel names were not rendered in thread list view unless channel was previously queried.
Before:
After: