Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hydrate channel instance from thread response #1354

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

myandrienko
Copy link
Contributor

Previously, Thread instance created an unitized Channel instance for the parent channel. The idea was that when the thread is rendered, it will be rendered inside the Channel component which will take care of initializing the instance.

However, it makes sense to expect at least some data in this channel instance: its name and members. This data is available in the thread response which is used to construct a Thread instance.

So now we try to hydrate the channel instance with whatever data we have. This fixes at least one known bug: channel names were not rendered in thread list view unless channel was previously queried.

Before:

Screenshot 2024-09-10 at 16 39 13

After:

Screenshot 2024-09-10 at 17 02 10

Copy link
Contributor

Size Change: +478 B (+0.11%)

Total Size: 426 kB

Filename Size Change
dist/browser.es.js 92.5 kB +102 B (+0.11%)
dist/browser.full-bundle.min.js 54.1 kB +49 B (+0.09%)
dist/browser.js 93.6 kB +113 B (+0.12%)
dist/index.es.js 92.5 kB +103 B (+0.11%)
dist/index.js 93.7 kB +111 B (+0.12%)

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants