Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix filter type for query reactions #1287

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix: fix filter type for query reactions #1287

merged 3 commits into from
Apr 30, 2024

Conversation

myandrienko
Copy link
Contributor

@myandrienko myandrienko commented Apr 30, 2024 •
edited
Loading

According to the implementation, reactions filter only supports the following fields:

  • user_id
  • type
  • created_at

So no need to include any other keys in the filter type. Adding all other keys from the Reaction type breaks the filter type, because Reaction type is overridable via generic params.

Also, adds pagination next field to response.

@myandrienko
Copy link
Contributor Author

@guerinoni FYI.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 368 kB

ℹ️ View Unchanged
Filename Size
dist/browser.es.js 79.4 kB
dist/browser.full-bundle.min.js 48.1 kB
dist/browser.js 80.4 kB
dist/index.es.js 79.5 kB
dist/index.js 80.5 kB

compressed-size-action

guerinoni
guerinoni approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@guerinoni guerinoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not super skilled in JS :)

@myandrienko myandrienko merged commit 65174a5 into master Apr 30, 2024
5 of 6 checks passed
@myandrienko myandrienko deleted the fix/reaction-filter-types branch April 30, 2024 14:16
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverlaz oliverlaz oliverlaz approved these changes

@guerinoni guerinoni guerinoni approved these changes

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

@santhoshvai santhoshvai Awaiting requested review from santhoshvai santhoshvai is a code owner

@khushal87 khushal87 Awaiting requested review from khushal87 khushal87 is a code owner

@szuperaz szuperaz Awaiting requested review from szuperaz szuperaz is a code owner

@arnautov-anton arnautov-anton Awaiting requested review from arnautov-anton arnautov-anton is a code owner

@MartinCupela MartinCupela Awaiting requested review from MartinCupela MartinCupela is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myandrienko @oliverlaz @guerinoni