Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable message composer shadow elevation #5697

Merged
merged 5 commits into from
Apr 1, 2025
Merged

Customizable message composer shadow elevation #5697

merged 5 commits into from
Apr 1, 2025

Conversation

andremion
Copy link
Contributor

@andremion andremion commented Mar 31, 2025 •
edited
Loading

🎯 Goal

Create ChatTheme.dimens.messageComposerShadowElevation so we can now customize the elevation of the message composer like this:

val dimens = StreamDimens.defaultDimens().copy(messageComposerShadowElevation = 0.dp)
ChatTheme(
    dimens = dimens,
   // Any other customizations
)

Fixes #5569

@andremion andremion added the compose Jetpack Compose label Mar 31, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 31, 2025 •
edited
Loading

SDK Size Comparison 📏

SDK Before After Difference Status
stream-chat-android-client 3.18 MB 3.18 MB 0.00 MB 🟢
stream-chat-android-offline 3.39 MB 3.39 MB 0.00 MB 🟢
stream-chat-android-ui-components 7.90 MB 7.90 MB 0.00 MB 🟢
stream-chat-android-compose 9.93 MB 9.93 MB 0.00 MB 🟢

@andremion andremion marked this pull request as ready for review April 1, 2025 08:08
@andremion andremion requested a review from a team as a code owner April 1, 2025 08:08
@andremion andremion mentioned this pull request Apr 1, 2025
Closed
@JcMinarro JcMinarro enabled auto-merge (squash) April 1, 2025 12:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JcMinarro JcMinarro merged commit 99d28b9 into develop Apr 1, 2025
14 checks passed
@JcMinarro JcMinarro deleted the custom-message-composer-elevation branch April 1, 2025 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
compose Jetpack Compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the elevation of the MessageComposer
2 participants
@andremion @JcMinarro