fix(Identifier): set default name as uuid #1102
Open
+28
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panquez
requested review from
BotellaA,
francoisbonneau,
MelchiorSchuh,
BenoitTHEBAULT and
BenPinet
|
@BotellaA I have done the change proposed in your comment. Please could you update the serialize to consider know an optional? |
Done |
BotellaA
approved these changes
Mar 18, 2025
|
Having an algorithm that checks if there is a name by checking the name value is for sure a really bad design choice!! When need a may to know when a name is set or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think about this change?