[Draft] seed: use Ellipsis to indicate keeping current seed #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used
np.nan
to indicate to keep the current seed in the RNG, which is a bit of a hack IMHO.Python provides a special built in constant to be used as placeholder: Ellipsis
In my opinion it is more intuitive to state
seed=...
to keep the seed in contrast toseed=np.nan
since we can't useNone
which is a special value for seeds. Since Python provides a dedicated constant to be used as a placeholder, I would use it here.