Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cython backend #1

Merged
merged 42 commits into from
Feb 3, 2025
Merged

Create cython backend #1

merged 42 commits into from
Feb 3, 2025

Conversation

MuellerSeb
Copy link
Member

@MuellerSeb MuellerSeb commented Jul 11, 2024 •
edited
Loading

  • only keept cython files
  • added tests for cython routines
  • added doc strings
  • added coverage for cython files in CI

@MuellerSeb MuellerSeb requested a review from LSchueler July 11, 2024 22:02
@MuellerSeb MuellerSeb marked this pull request as draft July 11, 2024 22:02
@MuellerSeb MuellerSeb mentioned this pull request Jul 13, 2024
Merged
@MuellerSeb
Copy link
Member Author

@LSchueler ready for a first review.

@MuellerSeb MuellerSeb marked this pull request as ready for review July 13, 2024 22:54
@LSchueler
Copy link
Member

Awesome! I'll have a closer look into this next week, looking forward to it.

LSchueler
LSchueler requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is going to make (development) life with GSTools much nicer :-)

A few things:

  • I think in the README.md you should make a comment that the user shouldn't be using this package directly. If you put this directly at the beginning, the rest of the document makes sense, with a short explanation of how to install the GSTools package rather than GSTools-Cython.

@MuellerSeb
Copy link
Member Author

@LSchueler this should be ready.

@MuellerSeb
Copy link
Member Author

LGTM

@MuellerSeb MuellerSeb merged commit 326a6d2 into main Feb 3, 2025
33 checks passed
@MuellerSeb MuellerSeb deleted the create_cy_backend branch February 3, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LSchueler LSchueler LSchueler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MuellerSeb @LSchueler