Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Replace conda-incubator/setup-miniconda with mamba-org/setup-micromamba in the Benchmarks workflow #3248

Merged
merged 1 commit into from
May 14, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented May 14, 2024

Description of proposed changes

Use mamba-org/setup-micromamba instead of conda-incubator/setup-miniconda so the workflow is consistent with all other workflows.

The tricky thing is that CodSpeedHQ/action doesn't support using the custom shell, so we need a workaround as mentioned in CodSpeedHQ/action#65.

Patches #2908.

This PR also removes the PROJ_LIB setting added in #3241, since it's no longer needed.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. run/benchmark Trigger the benchmark workflow in PRs labels May 14, 2024
@seisman seisman added this to the 0.13.0 milestone May 14, 2024
Copy link

codspeed-hq bot commented May 14, 2024

CodSpeed Performance Report

Merging #3248 will degrade performances by 39.53%

Comparing ci/benchmark (b54ec59) with main (9d0c02e)

Summary

❌ 1 regressions
✅ 98 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main ci/benchmark Change
test_load_libgmt 935.1 µs 1,546.5 µs -39.53%

Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, the performance regression on test_load_libgmt looks unrelated, not sure what happened there.

@seisman seisman removed needs review This PR has higher priority and needs review. run/benchmark Trigger the benchmark workflow in PRs labels May 14, 2024
@seisman seisman merged commit d2d79a3 into main May 14, 2024
6 of 7 checks passed
@seisman seisman deleted the ci/benchmark branch May 14, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants