-
Notifications
You must be signed in to change notification settings - Fork 229
SPEC 0: Set minimum supported versions to pandas>=1.5 and xarray>=2022.03 #3043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…03 in environment.yml
…03 in pyproject.toml
…03 in requirements.txt
doc/minversions.rst
Outdated
@@ -15,62 +15,64 @@ the rest of the Scientific Python ecosystem, and therefore: | |||
- Documentation | |||
- GMT | |||
- Python | |||
- NumPy | |||
- Core package dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #3037 (comment), @weiji14 proposed to add two more columns for pandas and xarray. I think this is not good, because the table is already too wide. I prefer to list the core dependencies in a single column. See https://pygmt-dev--3043.org.readthedocs.build/en/3043/minversions.html for preview.
I also prefer to combine the "Python version" and "Documentation" columns into a single column. The new table will look like:

Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer to combine the "Python version" and "Documentation" columns into a single column.
Yep, ok with this part. We can add a note at the bottom to say that 'Dev' reflects the main branch and is for the upcoming release.
In #3037 (comment), @weiji14 proposed to add two more columns for pandas and xarray. I think this is not good, because the table is already too wide. I prefer to list the core dependencies in a single column.
Once we combine the PyGMT and Docs columns, maybe there's enough space for separate numpy/pandas/xarray columns? Could you try splitting into individual columns to see how it looks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 5f22ecb. Not bad. See preview at https://pygmt-dev--3043.org.readthedocs.build/en/3043/minversions.html.
doc/minversions.rst
Outdated
@@ -15,62 +15,64 @@ the rest of the Scientific Python ecosystem, and therefore: | |||
- Documentation | |||
- GMT | |||
- Python | |||
- NumPy | |||
- Core package dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also prefer to combine the "Python version" and "Documentation" columns into a single column.
Yep, ok with this part. We can add a note at the bottom to say that 'Dev' reflects the main branch and is for the upcoming release.
In #3037 (comment), @weiji14 proposed to add two more columns for pandas and xarray. I think this is not good, because the table is already too wide. I prefer to list the core dependencies in a single column.
Once we combine the PyGMT and Docs columns, maybe there's enough space for separate numpy/pandas/xarray columns? Could you try splitting into individual columns to see how it looks?
Co-authored-by: Wei Ji <[email protected]>
aad31ee
to
5f22ecb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks @seisman!
After pinning pandas and xarray with Python 3.10, now we have many failures on macOS/Windows. See https://github.com/GenericMappingTools/pygmt/actions/runs/7946102470/job/21694725831. Need to find out why. |
|
Thanks. Will address the issue after this PR is merged. |
Description of proposed changes
requirements.txt
environment.yml
pyproject.toml
.github/workflows/ci_tests.yaml
doc/minversions.rst
https://pygmt-dev--3043.org.readthedocs.build/en/3043/minversions.htmlCloses #2863.