Skip to content

SPEC 0: Set minimum supported versions to pandas>=1.5 and xarray>=2022.03 #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Feb 18, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 6, 2024

Description of proposed changes

Closes #2863.

@seisman seisman changed the title SPEC 0: Set minimum required version to pandas>=1.5 and xarray>=2022.03 SPEC 0: Set minimum supported versions to pandas>=1.5 and xarray>=2022.03 Feb 6, 2024
@@ -15,62 +15,64 @@ the rest of the Scientific Python ecosystem, and therefore:
- Documentation
- GMT
- Python
- NumPy
- Core package dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #3037 (comment), @weiji14 proposed to add two more columns for pandas and xarray. I think this is not good, because the table is already too wide. I prefer to list the core dependencies in a single column. See https://pygmt-dev--3043.org.readthedocs.build/en/3043/minversions.html for preview.

I also prefer to combine the "Python version" and "Documentation" columns into a single column. The new table will look like:

image

Thoughts?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer to combine the "Python version" and "Documentation" columns into a single column.

Yep, ok with this part. We can add a note at the bottom to say that 'Dev' reflects the main branch and is for the upcoming release.

In #3037 (comment), @weiji14 proposed to add two more columns for pandas and xarray. I think this is not good, because the table is already too wide. I prefer to list the core dependencies in a single column.

Once we combine the PyGMT and Docs columns, maybe there's enough space for separate numpy/pandas/xarray columns? Could you try splitting into individual columns to see how it looks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seisman seisman added the maintenance Boring but important stuff for the core devs label Feb 6, 2024
@seisman seisman added this to the 0.12.0 milestone Feb 6, 2024
@@ -15,62 +15,64 @@ the rest of the Scientific Python ecosystem, and therefore:
- Documentation
- GMT
- Python
- NumPy
- Core package dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer to combine the "Python version" and "Documentation" columns into a single column.

Yep, ok with this part. We can add a note at the bottom to say that 'Dev' reflects the main branch and is for the upcoming release.

In #3037 (comment), @weiji14 proposed to add two more columns for pandas and xarray. I think this is not good, because the table is already too wide. I prefer to list the core dependencies in a single column.

Once we combine the PyGMT and Docs columns, maybe there's enough space for separate numpy/pandas/xarray columns? Could you try splitting into individual columns to see how it looks?

@seisman seisman force-pushed the spec0/pandas+xarray branch from aad31ee to 5f22ecb Compare February 17, 2024 14:21
@seisman seisman marked this pull request as ready for review February 18, 2024 02:49
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 18, 2024
@seisman seisman requested a review from a team February 18, 2024 02:49
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @seisman!

@seisman
Copy link
Member Author

seisman commented Feb 18, 2024

After pinning pandas and xarray with Python 3.10, now we have many failures on macOS/Windows. See https://github.com/GenericMappingTools/pygmt/actions/runs/7946102470/job/21694725831. Need to find out why.

@weiji14
Copy link
Member

weiji14 commented Feb 18, 2024

After pinning pandas and xarray with Python 3.10, now we have many failures on macOS/Windows. See https://github.com/GenericMappingTools/pygmt/actions/runs/7946102470/job/21694725831. Need to find out why.

pytest-mpl=0.17.0 now adds a metadata key into our savefig call (added in https://github.com/matplotlib/pytest-mpl/pull/196/files I think), and this is not handled by psconvert. We'll need to ignore that metadata key somehow.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Feb 18, 2024
@seisman
Copy link
Member Author

seisman commented Feb 18, 2024

After pinning pandas and xarray with Python 3.10, now we have many failures on macOS/Windows. See https://github.com/GenericMappingTools/pygmt/actions/runs/7946102470/job/21694725831. Need to find out why.

pytest-mpl=0.17.0 now adds a metadata key into our savefig call (added in https://github.com/matplotlib/pytest-mpl/pull/196/files I think), and this is not handled by psconvert. We'll need to ignore that metadata key somehow.

Thanks. Will address the issue after this PR is merged.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 18, 2024
@seisman seisman merged commit 823676f into main Feb 18, 2024
@seisman seisman deleted the spec0/pandas+xarray branch February 18, 2024 18:15
@weiji14 weiji14 added deprecation Deprecating a feature and removed maintenance Boring but important stuff for the core devs labels Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from NEP 029 to SPEC 0
3 participants