Skip to content

Upgrate Earth gravimetric recipes for SWOT data #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Esteban82
Copy link
Member

This PR is only to upgrade the recipes to use the SWOT grids (in this link https://topex.ucsd.edu/pub/global_grav_1min_SWOT/) instead of this ones (https://topex.ucsd.edu/pub/global_grav_1min/).

In the four recipes I change the precision (or scale) and offset. I also change the SRC_FILE, REF and DOI.

I think that only important thing that I want your approval is for the SRC_TITLE of each recipe.

See discussion on #271

@Esteban82 Esteban82 added the enhancement New feature or request label Apr 16, 2025
@Esteban82 Esteban82 requested review from joa-quim, anbj and a team April 16, 2025 15:25
@Esteban82 Esteban82 self-assigned this Apr 16, 2025
@joa-quim
Copy link
Member

Given the large differences in some of the grid's scale factor, I would be more comfortable to see what we are loosing with quantization to uint16. Again, a simple test is to compare the original floating point values at some nodes (obtained with grdtrack) with those in the scaled uint16 grids.

@Esteban82
Copy link
Member Author

Given the large differences in some of the grid's scale factor,

A comment on the grid factor. I believe that for earlier recipes, the scale was intended a range of 2^15 values. That is partly why I was so hesitant with this issue.

@joa-quim
Copy link
Member

2^15 if for signed ints (1/2 negatives & 1/2 positives). 2^16 is for unsigned ints

@Esteban82
Copy link
Member Author

I see, But I don't know why was set to signed ints. I don't know why we didn't saw that.

@joa-quim
Copy link
Member

Maybe Paul checked that current scales were enough to maintain the FAA up to the microGal, but I'm not so sure about the deflections.

@WalterHFSmith
Copy link

WalterHFSmith commented Apr 16, 2025 via email

@joa-quim
Copy link
Member

Walter,

This issue started when we realized that the new SWOT grid has a larger amplitude (SWOT minimum is ~400 mGal lower than the V32 version). Though a bit surprising, that is not the issue. The issue was that with the new SWOT's range Federico had a doubt on what would be a good scaling factor ... and conversations started. See #271 for more details.

@WalterHFSmith
Copy link

WalterHFSmith commented Apr 16, 2025 via email

@joa-quim
Copy link
Member

Walter, we are not talking about outliers.

diffs_faa

@WalterHFSmith
Copy link

WalterHFSmith commented Apr 17, 2025 via email

@joa-quim
Copy link
Member

Walter, you are right that it's on the Antarctica shore but I think you misunderstood what the figure represents. It shows the grid differences between the SWOT and previous V32 FAA's. I've added the coastline to make it clear.

only to say that the gravity anomaly, if expressed in integers representing 10^-6 m/s^2, should easily fit in a two-byte signed integer.

Yes, no doubt. The discussion was only on what new value (if any) should we use as scale for these new grids.

Easter truce in Washington?

Cheers

diffs_faa

@joa-quim
Copy link
Member

More I look at this more I think that this SWOT anomalies cannot be right. This is 3 times the amplitude of the anomaly across the Chile trench. @dsandwell

diffs_faa

@dsandwell
Copy link

Thanks for find the anomaly. This is probably an ishelf where there is a step in the ocean height due to ice. V32 is probably more accurate so I would use V32 around Antarctica. THere are some other issues with SWOT gravity related to the outer edges of the swaths. It will take a while to fix all of these.

@joa-quim
Copy link
Member

Glad to having contributed with something 👍

@Esteban82
Copy link
Member Author

Well, back to the subject of scale. I agree that the resolution of the data should be higher than that of the measurement. But I think it would be convenient to use a scale that maximizes the number of values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants