Fix place_candidate.sh #269
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joa-quim
approved these changes
Mar 19, 2025
|
Yes, it worked for me. My main doubt is what would happen in the case of doing something like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that
${dataset}was missing on line 69. This line is used to set permissions (chmod). I am not sure if the proposed modification is correct. But I think it makes sense seeing the message of the previous line.BTW, when I ran the script as is, it failed me with the earth_vgg and earth_synbath grids (and I don't know if any others). I think at the time Paul didn't change the permissions on those datasets. Maybe in the future we will have a problem when it is necessary to update them.
The modified script worked when I tried to run make place-earth-wdmam (#245). The original script failed me for the reasons mentioned in the previous paragraph.