Do not let -Bz trigger x-y basemap #4290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weiji14's codes still produce the incorrect basemap. |
|
All I know is that
no longer plots the x-y map whereas prior to this PR it did. But I see his script still gives the double whammy. Hm. |
|
Not sure why, but it happens because no -J is given for x-y. If you add -JM15c or similar there is not map. So need to see why this also triggers the setting of draw = true. |
|
I think the problem is -Bz. There is no way to tell if this is a subset of -BWweESsZz or -Bz as short for -Bzaf. |
|
Not out of the woods, but this PR is a start. It catches some of these, such as my example on top. |
seisman
approved these changes
Oct 6, 2020
|
#4181 is still not fixed, but at least your command works well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it says. Partly addresses #4181.