Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory #45

Merged
merged 7 commits into from
Oct 6, 2024
Merged

Fix memory #45

merged 7 commits into from
Oct 6, 2024

Conversation

ahuoguo
Copy link
Contributor

@ahuoguo ahuoguo commented Oct 2, 2024

  • fixes memory, we initially load with big endian style

Some notes on testing

2o1u-unlabeled.wat is generated by wat2wasm 2o1u.wat && wasm2wat 2o1u.wasm -o 2o1u-unlabeled.wat to remove the labels.

There are two ways to get runtime information

  1. wat2wasm 2o1u.wat && node start.js, this will directly use the Console.log from JS. This is more like a println way for debugging
  2. (preferred) Use wizard engine. Try wat2wasm 2o1u.wat && wizeng.jar -tio 2o1u.wasm. This will give full runtime information (stack, locals, etc.). There are also more monitoring options.

For now, the branching of MiniWasm is wrong since the tos at the trap in func 3 is 0 instead of 1 after i32.load

Base automatically changed from fix-loop to main October 2, 2024 21:09
@ahuoguo ahuoguo marked this pull request as ready for review October 3, 2024 00:13
@Kraks
Copy link
Member

Kraks commented Oct 4, 2024

Is this hook used to run the benchmark in node.js? Now our interpreter can deal with console.log, it would be great if the benchmark works for that too.

@ahuoguo
Copy link
Contributor Author

ahuoguo commented Oct 4, 2024

Is this hook used to run the benchmark in node.js?

Yes.

I will try if this runs on the interpreter.

@ahuoguo ahuoguo changed the title hook for 2o1u More observability for 2o1u Oct 5, 2024
@ahuoguo ahuoguo changed the title More observability for 2o1u Fix memory Oct 5, 2024
@ahuoguo ahuoguo merged commit ea20ef7 into main Oct 6, 2024
1 check passed
@Kraks Kraks deleted the fix-mem branch October 9, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants