Allow adding headers to switching protocols response #125
Conversation
Signed-off-by: Jens Reidel <[email protected]>
Gelbpunkt
force-pushed
the
switching-protocols-headers
branch
from
223d152 to
c65bdbc
Compare
| resp.extend_from_slice(ws_accept.as_bytes()); | ||
| resp.extend_from_slice(b"\r\n"); | ||
|
|
||
| for (name, value) in self.response_headers { |
There was a problem hiding this comment.
IntoIter yields the same key multiple times in case of multiple values, yet http expects headers to be formated as key: value1,value2. You can use keys() and get_all() instead
There was a problem hiding this comment.
I had that done at some point in the implementation, but there are special cases to consider here (Set-Cookie). I'm not sure whether that's worth the added complexity considering this is probably going to be used to set 1-2 extra headers, if at all
There was a problem hiding this comment.
I did not know about that exception. But we should document the behavior then.
There was a problem hiding this comment.
See https://www.rfc-editor.org/rfc/rfc7230#section-3.2.2, this is not super trivial
There was a problem hiding this comment.
I meant to document that adding multiple values to a header may produce a noncompliant request
Should fix #119, cc @lehmanju