WIP: Added some missing field info to the EngineApi interface #2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -63,11 +63,12 @@ extern bool VectorResize(U32 *aSize, U32 *aCount, void **arrayPtr, U32 newCount, | |||
| template<class T> | |||
| class Vector | |||
| { | |||
| protected: | |||
| public: | |||
There was a problem hiding this comment.
quite dangerous, completely breaks encapsulation...
There was a problem hiding this comment.
Yes I forgot I made that change in there, wanted to bring it up and ask if there were another way to do it.. Maybe moving the Implement Struct to somewhere associated with Vector?
There was a problem hiding this comment.
An alternative solution is hard-coding the offsets:
IMPLEMENT_STRUCT( Vector< bool >,
BoolVector,,
"" )
{"elementCount", "", 1, TYPE<U32>(), 0},
{"arraySize", "", 1, TYPE<U32>(), 4},
{"array", "", 1, TYPE<bool*>(), 8},
//FIELD(mElementCount, elementCount, 1, "")
//FIELD(mArraySize, arraySize, 1, "")
//FIELD(mArray, elements, 1, "")
END_IMPLEMENT_STRUCT;There was a problem hiding this comment.
Or the offsets could be computed and defined in tVector.h, but that sort of breaks encapsulation as well.
lukaspj
changed the title
|
Added WIP tag, until we can figure out how to handle Vector stuff. |
|
Structs that have access permission issues:
|
|
Closed in favor of #2366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably doesn't have any effect on how the engine works, but it is nice for documentation and engine API export purposes.