don't treat skipped jobs as cancelled #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a workflow causes a job to not run (due to a false `if` condition), don't treat the job (and thus the whole workflow) as cancelled
|
👍 This would be a great improvement to an already great plugin! Currently you get a perfectly 🟢 build on GitHub... |
|
What happens when some of the jobs are failed and dependent job is canceled? |
|
you will get a failed notification for the failed job anyways which will mark the slack notification as partially failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a workflow causes a job to not run (due to a false
ifcondition), don't treat the job (and thus the whole workflow) as cancelled.In our case, we have a workflow with a conditional step (in order to not attempt to run a deployment on pull requests). Currently, slack-workflow-status would treat the complete workflow as cancelled and post a warning message to slack whenever the condition was false.
I don't think this makes sense: If a step is deliberately skipped, it means it wasn't relevant for the workflow and thus, it should not affect the reporting.