ENH k-space wrapping for Hermitian images #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
commented
Sep 22, 2023
beckermr
commented
Sep 22, 2023
beckermr
commented
Sep 22, 2023
There was a problem hiding this comment.
This test file is redundant so I removed it.
beckermr
commented
Sep 22, 2023
beckermr
commented
Sep 22, 2023
| return contract_hermitian_y(im_exp) | ||
|
|
||
|
|
||
| # I am leaving this code here for posterity. It has a bug that I cannot find. |
There was a problem hiding this comment.
@rmjarvis @jecampagne If any of you have a chance to look for bugs in the code below, that'd be cool. No worries if not!
ismael-mendoza
approved these changes
Sep 29, 2023
beckermr
commented
Sep 30, 2023
|
I am merging this code with the fixes to address the PR comments above into PR #60 since it is needed for tests there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a very naive, but working implementation of k-space wrapping for Hermitian images. The code expands the image from its compressed format to the fully explicit Hermitian format, wraps then using simple code, and then cuts away the parts not needed.
I tried a more memory efficient algorithm that didn't involve the expansion but could not get it working. I've left that code commented out in case someone else can find the bug.
todo: