fix: fishing zombie throwing rod while dead #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes GTNewHorizons/GT-New-Horizons-Modpack#17058
EntityFishingZombie uses a different implementation (using
onLivingUpdate
) for the fishing hook logic than EntityFishingPigZombie and EntityFishingSilverfish.This is necessary because the base Zombie uses the modern AI Task System, where
attackEntity
isn't used anymore.An oversight was made however:
attackEntity
doesn't get called if the Entity is dead, butonLivingUpdate
does.This causes Fishing Zombies to be able to throw Fishing Rods while dead (in the Dying animation before the entity is deleted).
0031856.mp4
(Note the fishing rod bobber being being thrown after the Zombie is killed. This can still hit and pull players)

Just adding a check with
isMovementBlocked
fixes this (using this function instead of isDead seems to be convention for stopping Mob AI).