Refactor AE Transfer Chip #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready |
serenibyss
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a draft.Ready
Refactor AE Transfer Chip code to solve the problem of unexpected disconnection and other unpredictable behaviours.
This PR:
1.Remove LinkedGridNode.java, it's no longer used.
2.TileRemoteInterface no longer disguise itself as remote AE TileEntity to trick AE channel pathing system.
Remove 'implements IGridHost&IGridBlock'.
3.TileRemoteInterface now actively create&destroy remote GridConnection when needed.
before.mp4
after.mp4
working.fine.without.ae.mp4