Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ASM coremod #15

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Delete ASM coremod #15

merged 1 commit into from
Oct 23, 2024

Conversation

Alexdoru
Copy link
Member

@Alexdoru Alexdoru commented Oct 23, 2024

This mod adds a block that you can link to another block and it will emulate the behavior of the linked block. If you add a camouflage upgrade to it, it will also render as the linked block.

To achieve this this mod had ASM doing unecessary transformations to the Tessellator class.

I removed all the ASM and it works the same.

How to use the block the review this PR:

  • place down a "remote interface"
  • right click on the "remote interface" with a "remote camouflage upgrade"
  • sneak right click with a "location ship" on the block you want to link
  • right click on the "remote interface" with the "location ship" to establish the link

@Alexdoru Alexdoru marked this pull request as draft October 23, 2024 15:49
@Alexdoru Alexdoru changed the title reduce alloctation in coremod Delete ASM coremod Oct 23, 2024
@Alexdoru Alexdoru marked this pull request as ready for review October 23, 2024 16:34
@Dream-Master Dream-Master requested a review from a team October 23, 2024 16:41
@boubou19 boubou19 merged commit 5c73e86 into master Oct 23, 2024
1 check passed
@boubou19 boubou19 deleted the asm branch October 23, 2024 22:27
@Alexdoru
Copy link
Member Author

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants