feat(appeng): integrate StackApi for full fluid and essentia support.#169
Open
hinyb wants to merge 8 commits intoGTNewHorizons:masterfrom
Open
feat(appeng): integrate StackApi for full fluid and essentia support.#169hinyb wants to merge 8 commits intoGTNewHorizons:masterfrom
hinyb wants to merge 8 commits intoGTNewHorizons:masterfrom
Conversation
Dream-Master
added
the
🚧 Testing on Zeta
This comment was marked as resolved.
This comment was marked as resolved.
hinyb
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
hinyb
changed the title
Member
|
Possibly causes GTNewHorizons/GT-New-Horizons-Modpack#23349 |
3 tasks
|
I have tested the build artifact and my crashes have gone away, no new issues. |
Member
|
we need to find some one review it. |
BREAKING CHANGE: update the parameter order of `setPatternSlot` to align with `storeInterfacePattern` and `clearInterfacePattern`
hinyb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the old logic via new StackAPI, providing full support for fluid and essentia, matching the esisting item support.
Breaking Changes
To maintain consistency across the API, update the parameter order of
setPatternSlotto align withstoreInterfacePatternandclearInterfacePatternfunction(slot:number, database:address, entry:number, size:number, index:number)function(slot:number, index:number[, database:address, entry:number, size:number]):booleanChanges:
fix GTNewHorizons/GT-New-Horizons-Modpack#19874
fix GTNewHorizons/GT-New-Horizons-Modpack#19567
fix GTNewHorizons/GT-New-Horizons-Modpack#20839
fix GTNewHorizons/GT-New-Horizons-Modpack#23349