Fix some weird memory leak from changing dimensions

[kuba6000]

Changed to ItemStackMap
before:

[github-actions]

Warning: 2 uncommitted changes
#582

[Glease]

isn't the map supposed to remove the oldest entry since 20 elements? is that broken?

[kuba6000]

isn't the map supposed to remove the oldest entry since 20 elements? is that broken?

probably, as you can see in the screenshot of memory dump

[Glease]

what java version are you using? in gt5 dev env it definitely don't do it

[kuba6000]

what java version are you using? in gt5 dev env it definitely don't do it

jdk-22

[slprime]

Won't this create a memory problem since this method is called every time you hover over an object in world?

[slprime]

and this can't solve problem, only hide it

[slprime]

#583 - this PR solved the problem better

[Glease]

This map has some race condition problem. I bet this is just the fallout of that and neither PR would really work. I suggest to wrap it around synchronizedMap instead.

GT5 dev env doesn't have this issue because there is simply no contention there. The top offender lives in GC where it's calling getFluid as part of its tooltip event handler.