Concurrent recipe profiler #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slprime
requested changes
May 4, 2024
|
Null sections are treated as |
slprime
approved these changes
May 4, 2024
Dream-Master
pushed a commit
that referenced
this pull request
May 4, 2024
* concurrent recipe profiler * eliminate NPE by giving nulls a name (cherry picked from commit 5056fe5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually profiles every recipe handler and show them.
Now that finding both crafting and usage recipes runs in parallel, the percentage statistics are removed, but the
totalTimefield are kept for backwards compatibility.Added the missing localization of profiler section
nei.recipe.concurrent.usageandnei.recipe.concurrent.usage.Fixed a potential performance issue, where ItemStack can be normalized in-place than an overhead of streaming operations.
Field-Tested in latest GTNH and a Reika modpack of my own.