Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DnD big ItemStack; Show green slot highlighting overlay #463

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

slprime
Copy link
Member

@slprime slprime commented Feb 21, 2024

Show small itemStack when DnD

before after
image image

Highlighting existing items

image

@Caedis
Copy link
Member

Caedis commented Feb 21, 2024

The reason I didnt show green and red is because of red/green color blindness.
Only show 1 or the other, but not both.

@Dream-Master
Copy link
Member

I ask him to add this because before it had a green V before and if i have all ingredients it show nothing which confuse me.

@Caedis
Copy link
Member

Caedis commented Feb 21, 2024

We have decided. Keep the red and green, but change the default to false for the config added in #458

@slprime
Copy link
Member Author

slprime commented Feb 21, 2024

image

Item Overlay on ?-Hover - have 3 values: None, Icon, Background
Highlight Present Item - Yes, No

Item Overlay on ?-Hover join 2 options in one. JEI Style Item Overlay on ?-Hover and Highlight the entire slot instead of just showing an icon for the recipe overlay

Default
image

@slprime
Copy link
Member Author

slprime commented Feb 21, 2024

icon background
image image
image image

@Caedis
Copy link
Member

Caedis commented Feb 21, 2024

Perfect

@slprime slprime requested a review from Caedis February 21, 2024 20:27
@slprime slprime marked this pull request as draft February 21, 2024 21:56
@slprime slprime marked this pull request as ready for review February 21, 2024 23:01
@Dream-Master Dream-Master merged commit 94676e0 into GTNewHorizons:master Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants