-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Bookmarks Groups; Search Recipe #451
Create Bookmarks Groups; Search Recipe #451
Conversation
How difficult would this be for you to split this up into multiple PRs? We prefer PRs be 1 feature at a time, and with a codebase like NEI (you are probably already aware), it can get messy for reviewers and if something needs to be reverted. Also, can an icon be added to the recipe page to make it more obvious that the player can search from there (maybe a magnifying glass)? 1 PR for each feature, and then another for the general optimizations/fixes. |
|
Have you tested this with a dedicated server/in the full pack? |
tested at least 5 people for a week |
|
What's the possibility of adding the ability to include a craftables tab which shows all the possible items you can currently craft based on your current inventory? That combined with your bookmarks feature would be a godsend for early game bulk crafting. |
I'm not sure that the detailed functionality will be acceptable in terms of speed |
I'm a GTNH streamer. I play on a dedicated GTNH server (native, not modified). I tested all the above features on my stream with my viewers. Everything works great and is very useful. |
LGTM, but i want 1 more dev to review to make sure I didnt miss anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the recipe search in particular is amazing.
the main problem I see is that there is no way for players to know about these features.
Please consider some changes in that direction. Options include, but are not limited to:
- making the GUIs for the crafting search and for the presets actually visible
- writing quests about these features
Looks great |
I'm reworking the recipe search algorithm. The current one has problems with additional recipe data such as essence, voltage and more. I have an idea how to make it more flexible |
8aded63
to
316494d
Compare
e0bdbf6
to
d64c270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works in sp game and in the zeta server. Tested for around 3 weeks.
Sory for google translate :)
crafting-chains.mp4
remove-group.mp4
Create Groups in Bookmarks
LMB
and pull it up or down. To delete a group, grab it with RMB and also drag it up or downLMB
shift+ctrl+a
orshift+a
, and then another crafting result without shift.shift+a
Created Search Recipe Functionality
Closes #252
ctrl+shift+alt+scroll
GT_NewHorizons2.5.12024-01-1100-13-54-ezgif.com-video-speed.mp4
Presets
filteredrecipes.mp4
AE2FC
ae2fc.mp4
Ability to hide specific handlers
Closes #180
Closes #406
Closed GTNewHorizons/GT-New-Horizons-Modpack#15059
You can now hide handlers added it
handler.getHandlerId()
orhandler.getOverlayIdentifier()
inconfig/NEI/hiddenhandlers.csv
fileRecipe Tooltip
Closes #408
Closes GTNewHorizons/GT-New-Horizons-Modpack#14360
tooltip.mp4
Closes #280
Pull all Bookmarked Items
V
on a group marker - pull all items with this groupshift+V
on a group marker - pull all ingredients in this group. if group in linked mode (green)shift+v
pull only input ingredientsOthers