Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTRL-click [+] in NEI to craft missing items to AE2FC terminal #43

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

niklasstich
Copy link

Fixes "Ctrl-click [?] to request missing items from a NEI recipe" from GTNewHorizons/GT-New-Horizons-Modpack#16193
(and possibly "Ignore Missing Crafting Mode" if I understood it correctly?)

Please test thoroughly as I am new to both Minecraft modding and Java and have no idea what I'm doing 🙃

@niklasstich
Copy link
Author

I just built this branch again and put the dev jar into my 702 nightly version, doesn't work there. So I'll mark this as a draft until someone can test this.

@niklasstich niklasstich marked this pull request as draft October 27, 2024 15:06
@Alexdoru
Copy link
Member

I just built this branch again and put the dev jar into my 702 nightly version, doesn't work there. So I'll mark this as a draft until someone can test this.

the dev jar only works for dev environments, if you want to test in the full pack you have to use the .jar that doesn't say "dev" or "sources"

@slprime
Copy link
Member

slprime commented Oct 27, 2024

I haven't analyze this PR thoroughly, but it doesn't happen to be similar to - #42

At Dream request it was approve after the release of 2.7.0

@lordIcocain
Copy link

lordIcocain commented Oct 27, 2024

@slprime Hey, i just tested your pr, in it for ae2fc universal completly lack of features shift-click and ctrl-click. Current ae2fc at least have shift-click.

upd. only shift-click is not working. ctrl is fine.

@slprime
Copy link
Member

slprime commented Oct 27, 2024

@slprime Hey, i just tested your pr, in it for ae2fc universal completly lack of features shift-click and ctrl-click. Current ae2fc at least have shift-click.

upd. only shift-click is not working. ctrl is fine.

I'll check shift-click.

P.S. There i tried to fix all the terminals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants