Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slab Refactor, Leaf Refactor, and Everything Burns #29

Merged
merged 8 commits into from
Jan 20, 2025

Conversation

Ruling-0
Copy link

@Ruling-0 Ruling-0 commented Jan 16, 2025

In which I go from an issue which says "just uncomment this line" to finishing part of the 1.7.10 migration of Natura, 10 years later.

First, slab refactor. Natura slabs now inherit from the base BlockSlab, and can now do things like double stack!

image
Those aren't blocks, they're double slabs

I've also updated the log block updates to correctly mirror 1.7.10 logic (it was outdated) and removed the leaf logic (it was also outdated and at best not doing anything, at worst keeping leaves from not decaying when manually placed). Leafs now also have proper metadata functions, which means pick block works correctly and certain leaves no longer autodecay when manually placed.

Finally, now everything burns. Those double slabs previously?
image
The nether woods are fire immune.

This applies to all the wooden products, even fences!
image

And now, you can finally give that redwood tree the treatment it deserves.
https://github.com/user-attachments/assets/28493878-73a9-4bf8-b4d0-bfa6ce637bad

fixes GTNewHorizons/GT-New-Horizons-Modpack#9644
fixes GTNewHorizons/GT-New-Horizons-Modpack#18640

The deleted files are unreferenced classes.

@Ruling-0
Copy link
Author

Ruling-0 commented Jan 17, 2025

Fixed the extra Eucalyptus double slab bug. Copying how the vanilla BlockWoodSlab handled subblock registration apparently doesn't work in the modded case. I assume the vanilla version is part of how double slabs are hidden in NEI, but these and BoP's remain. Or that's a separate NEI thing.

@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 19, 2025
@Ruling-0
Copy link
Author

Updated to fix GTNewHorizons/GT-New-Horizons-Modpack#18640 by fixing issues with leaf metadata handling being incorrect.

@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 20, 2025
@serenibyss serenibyss merged commit 21965a4 into GTNewHorizons:master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain Natura leaves decay despite being placed Redwood leaves doesn't burn
2 participants