This repository has been archived by the owner on May 25, 2024. It is now read-only.
Make the Neutron Activator UI always report kinetic energy in MeV. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Neutron Activator GUI would use the generic MUI number formatting function to report its kinetic energy in appropriate units (k, M, G) depending on the amount of KE stored. However, this has proven impractical at the high end of the scale: any amount of energy between 1e9 and 1.1e9 eV would simply be reported as "1 GeV". This is insufficient granularity for the player to know whether it is ready to run a recipe. For instance, the Naquadria-Rich Solution recipe needs the KE to be between 1,050 MeV and 1,100 MeV.
This PR makes the GUI always report the energy in MeV, as this is the unit used in all NEI diagrams and probably the most relevant one to the player.