This repository has been archived by the owner on May 25, 2024. It is now read-only.
Add missing compact mk5 OC #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an edge case where a mk4 recipe has too high of a startup cost to get OCd by a mk5 compact, even though the recipe voltage would allow for it. This PR fixes that by adding a check for this exact scenario, which adds 1 OC.
Rhugnor was such an edge case and was the exact same speed in a mk4&mk5 compact, which is obviously wrong. With this PR it receives 1 OC as expected (going from 25.6 to 6.4 seconds)
