Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo rocket fuel #90

Merged
merged 6 commits into from
Jul 27, 2024
Merged

Conversation

Reflex18
Copy link

@Reflex18 Reflex18 commented Jul 26, 2024

This PR fixes the cargo rocket not accepting any fuel type. It does not fix it exploding on launch.

Reflex18 and others added 5 commits February 19, 2024 18:09
Testing if changing tier to 2 means that rocket fuel will be accepted.
hopefully fixes missing fuel for cargorocket
@Dream-Master
Copy link
Member

Does this fix the cargo rocket explode when landed as well? Issue was reported need to check it and link it here if so.

@Dream-Master Dream-Master requested a review from a team July 27, 2024 02:20
@Reflex18
Copy link
Author

Does this fix the cargo rocket explode when landed as well? Issue was reported need to check it and link it here if so.

No sadly it didnt which was why i didn't post it when i made the changes many months ago.
I might of messed something up since it appears to have some conflicts but i am not sure if that is an issue.

@glowredman
Copy link
Member

This wouldn't allow any higher tier fuel to be used - is this intended?

@Dream-Master
Copy link
Member

@Reflex18

@Reflex18
Copy link
Author

Oh no that isnt intended, it should take in any rocket fuel since it is classed as a tier two rocket.

@Dream-Master
Copy link
Member

So can you make a fix ?

Copy link
Member

@glowredman glowredman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, misread the code (which I wrote... 🤦‍♂️) - all good!

@Dream-Master Dream-Master merged commit 406913d into GTNewHorizons:master Jul 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants