Disable problematic glRotate for Angelica compat #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning: 2 uncommitted changes |
Co-authored-by: GitHub GTNH Actions <>
|
Why not just wrap it in a mod check? |
|
We could, but I tested with this change and without Angelica and it didn't seem to effect anything |
|
Might as well. It could be doing something subtle |
|
Did some investigation, and TL;DR I think it's safe to delete this line entirely. Details in this comment: Could maybe add a link in a code comment to GTNewHorizons/Angelica#379? Then future readers can see the reason it was removed, and what we know about it. |
eigenraven
approved these changes
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for GTNewHorizons/Angelica#379.
Disabling this section seems to fix the camera issues with space stations, and as far as I can tell doesn't break/change anything else. It doesn't seem to break anything without Angelica, and with Angelica it fixes the above issue and doesn't change anything else that I could find.
Would appreciate more testing as I'm not super familiar with later game space exploration content.