Add config option + Translucency enchant to hide GC gear from rendering on the player body #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or respect Translucency enchantment on it
serenibyss
reviewed
Feb 23, 2025
src/main/java/micdoodle8/mods/galacticraft/core/entities/player/GCPlayerHandler.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the Translucency II enchantment to work on the Galacticraft gear (oxygen mask, frequency module, thermal gear, tanks, etc), allowing you to hide them permanently. Previously, applying the enchantment was possible, but did nothing.
Alternatively, I have also added a config option instead to just stop rendering of the gear completely.