-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up recipes #11
Clean up recipes #11
Conversation
OneEyeMaker
commented
Mar 16, 2024
- Added support for recipes with OreDictionary entries as inputs.
- Fixed #10 by properly handling OreDictionary ingredients.
- General cleanup of recipe registration.
Used existing methods to improve readability
Allowed usage of OreDictionary entries as inputs
Removed some magic numbers
Oh, I didnt solve any of this since this mod wasnt going to be included in the pack, but I think that someplayers use it as an opcional aditional mod |
@OneEyeMaker is there a build of this somewhere? the artifact from the actions expired and we don't care enough to set up building rn... or we suppose we can just fork it and let it run. EDIT: ... can branches have releases? EDIT2: ended up forking, pull requesting ourselves and building it via actions on that repo :V EDIT3: ended up just using the original mod, this version is highly dependent on GTNH content. |
Hate to rain on your parade, but this mod has been guaranteed to not get into the pack by admins. Tho I do appreciate fixing magic mods for the sake of it |
Yeah we gathered that much. We're mostly looking to using it in our own pack unrelated to GTNH :P |
It'd be cool to see the mod more fixed up but alas, the current state of the code is highly dependent on GTNH modifications to recipes |