Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up recipes #11

Merged
merged 10 commits into from
Sep 1, 2024
Merged

Clean up recipes #11

merged 10 commits into from
Sep 1, 2024

Conversation

OneEyeMaker
Copy link
Contributor

  • Added support for recipes with OreDictionary entries as inputs.
  • Fixed #10 by properly handling OreDictionary ingredients.
  • General cleanup of recipe registration.

@OneEyeMaker OneEyeMaker requested a review from a team March 16, 2024 12:28
@EnderProyects
Copy link
Contributor

Oh, I didnt solve any of this since this mod wasnt going to be included in the pack, but I think that someplayers use it as an opcional aditional mod

@msparkles
Copy link

msparkles commented May 30, 2024

@OneEyeMaker is there a build of this somewhere? the artifact from the actions expired and we don't care enough to set up building rn...

or we suppose we can just fork it and let it run.

EDIT: ... can branches have releases?

EDIT2: ended up forking, pull requesting ourselves and building it via actions on that repo :V

EDIT3: ended up just using the original mod, this version is highly dependent on GTNH content.

@Alastors
Copy link

Hate to rain on your parade, but this mod has been guaranteed to not get into the pack by admins. Tho I do appreciate fixing magic mods for the sake of it

@msparkles
Copy link

Yeah we gathered that much. We're mostly looking to using it in our own pack unrelated to GTNH :P

@msparkles
Copy link

It'd be cool to see the mod more fixed up but alas, the current state of the code is highly dependent on GTNH modifications to recipes

@boubou19 boubou19 merged commit 78428d7 into master Sep 1, 2024
1 check passed
@boubou19 boubou19 deleted the cleanup-recipes branch September 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash
5 participants