forked from AE2-UEL/AE2FluidCraft-Rework
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Shift to pause terminal view movement #256
Merged
serenibyss
merged 11 commits into
GTNewHorizons:master
from
michaeldoylecs:feature-shift-pause
Jan 13, 2025
Merged
[Feature] Shift to pause terminal view movement #256
serenibyss
merged 11 commits into
GTNewHorizons:master
from
michaeldoylecs:feature-shift-pause
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
519 is a pre version
That should get it building unless you dep on any of the changes in the ae2 pr |
There are dependencies. The implementation depends on changes to IDisplayRepo in AE2-Unofficial. |
Gotcha, then this will have to wait for that pr |
serenibyss
reviewed
Jan 8, 2025
serenibyss
approved these changes
Jan 13, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTNewHorizons/GT-New-Horizons-Modpack#18420
See GTNewHorizons/Applied-Energistics-2-Unofficial#652 for the AE2-Unofficial related PR.
This is my attempt to reimplement #188, which was reverted in #206.
While the player is holding shift, the FluidRepo/EssentiaRepo enters a paused state. When paused, instead of clearing the view and display buffers entirely and filling them from the server entries, the existing view buffer is maintained and the existing view items are updated from the server entries. Any items that were not previously in the view are appended to the end of the view. Sorting is disabled while paused.
I have tested this on the world provided in the original reversion, but I would love some massively updating AE2 systems to test performance on, as well as any advice on how to go about testing ae2 performance outside of monitoring MSPT. I haven't run into any noticeable FPS TPS issues in my testing, but since the previous attempt had to be reverted I would love addition eyes.
I am not familiar with how to handle the dependency on AE2-Unofficial updating that this PR depends on, so advice is needed.