Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Shift to pause terminal view movement #256

Merged
merged 11 commits into from
Jan 13, 2025

Conversation

michaeldoylecs
Copy link

@michaeldoylecs michaeldoylecs commented Jan 5, 2025

GTNewHorizons/GT-New-Horizons-Modpack#18420

See GTNewHorizons/Applied-Energistics-2-Unofficial#652 for the AE2-Unofficial related PR.

This is my attempt to reimplement #188, which was reverted in #206.

While the player is holding shift, the FluidRepo/EssentiaRepo enters a paused state. When paused, instead of clearing the view and display buffers entirely and filling them from the server entries, the existing view buffer is maintained and the existing view items are updated from the server entries. Any items that were not previously in the view are appended to the end of the view. Sorting is disabled while paused.

I have tested this on the world provided in the original reversion, but I would love some massively updating AE2 systems to test performance on, as well as any advice on how to go about testing ae2 performance outside of monitoring MSPT. I haven't run into any noticeable FPS TPS issues in my testing, but since the previous attempt had to be reverted I would love addition eyes.

I am not familiar with how to handle the dependency on AE2-Unofficial updating that this PR depends on, so advice is needed.

@Caedis
Copy link
Member

Caedis commented Jan 5, 2025

That should get it building unless you dep on any of the changes in the ae2 pr

@michaeldoylecs
Copy link
Author

There are dependencies. The implementation depends on changes to IDisplayRepo in AE2-Unofficial.

@Caedis
Copy link
Member

Caedis commented Jan 5, 2025

Gotcha, then this will have to wait for that pr

@serenibyss serenibyss added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants