Preserve visually hidden text within license link #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting.. This looks good. I haven't tested it, but makes sense that it would be a problem in Svelte. Thanks @thibaudcolas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current editor output, the
sanitize-htmlfiltering causes thevisuallyhiddenclass to be removed:I looked at what might be the correct fix based on the sanitize-html docs for
allowedClass, but didn’t actually test this code.There are two alternative fixes here that might be better suited:
sanitizeHtmlaltogether. At least currently this code only outputs content from spdx-license-list, which I’d assume is trusted enough with how they define URLs and license names.target="_blank"and<span>(opens in a new window or tab)</span>for simplicity.