Feature/remove junk 2 #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attorri
requested review from
km719,
yogitabholwankar,
sungjeonchoi and
arnayv-47
arnayv-47
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is how it works. it modifies all buttons on each page with 'preview....OMB...' and 'evidenceportal' to just turn into 'evaluation.gov'/${evidenceportal_section}'
This is specifically designed for production.
The reason I do not use the url of the feature branch preview link is due to the fact that currently any feature branch link with evidence portal will default back to 'OMB-3-Release...'.
Hence, it must be set up this way.
Consider the for 'evidence portal' button on the home page as an example -
https://federalist-a1f29504-db06-4d32-992e-c2dadbfe82f2.sites.pages.cloud.gov/preview/gsa/eoc/feature/remove-junk-2/