Staging #759
Merged
Staging #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogpweb 16803
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!newSrc.includes("autoplay=1")) { | ||
| newSrc = newSrc.includes("?") ? `${newSrc}&autoplay=1` : `${newSrc}?autoplay=1`; | ||
| } | ||
| mainVideo.setAttribute("src", newSrc); |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
attorri
approved these changes
Feb 12, 2025
PaulaBannerman
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes approved by PO
Jira Story: https://cm-jira.usa.gov/browse/OGPWEB-16803
Preview Link: https://federalist-4be496a3-cca3-4187-b4d4-c3d573ae3139.sites.pages.cloud.gov/preview/gsa/ussm/staging/m3/
Add new videos and establish m3 video section. Add js player to allow videos to play in section without having to reload page. Also updated js to allow for title to change below video player.
Use: The main video player is updated whenever a thumbnail is clicked. Once a thumbnail on the right column is clicked the title under the main video will update and along with the video. This allows all three videos to be played on the same screen without having to reload the page as it's handled internally in the m3.js.