Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increased CICD CodeDeploy timeout #98

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Increased CICD CodeDeploy timeout #98

merged 1 commit into from
Feb 13, 2025
+1 −1

Conversation

igoristic
Copy link
Contributor

Summary

Our current CICD CodeDeploy pipeline times out while installing python 3.12, so it needs at lease more than 30min

Functionality Checks

  • You have merged the latest changes from the target branch (usually main) into your branch.

  • Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.

  • PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.

  • Automated checks pass. If Code Climate checks do not pass, explain reason for failures:

Process Checks

  • You have specified at least one "Reviewer".

@igoristic igoristic self-assigned this Feb 12, 2025
selfdanielj
selfdanielj approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@selfdanielj selfdanielj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

IsabelLaurenceau
IsabelLaurenceau reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@IsabelLaurenceau IsabelLaurenceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we actually need this anymore? What do you all think? I feel like adding the extra storage really accomplished what this was meant to

@selfdanielj
Copy link
Contributor

selfdanielj commented Feb 13, 2025 •
edited
Loading

I don't think we actually need this anymore? What do you all think? I feel like adding the extra storage really accomplished what this was meant to

It did time out once though right?

@IsabelLaurenceau
Copy link
Contributor

I don't think we actually need this anymore? What do you all think? I feel like adding the extra storage really accomplished what this was meant to

It did time out once though right?

That's true I forgot about the first run. Okay I'll approve

@IsabelLaurenceau IsabelLaurenceau self-requested a review February 13, 2025 14:21
@IsabelLaurenceau IsabelLaurenceau added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 19dde36 Feb 13, 2025
1 check passed
@igoristic igoristic deleted the increase_cicd_timeout branch February 13, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfdanielj selfdanielj selfdanielj approved these changes

@IsabelLaurenceau IsabelLaurenceau IsabelLaurenceau approved these changes

Assignees

@igoristic igoristic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igoristic @selfdanielj @IsabelLaurenceau