Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments about arguments to op declarations #119

Merged
merged 3 commits into from
Mar 10, 2025

Conversation

tsymalla
Copy link
Contributor

No description provided.

@tsymalla-AMD tsymalla-AMD requested a review from Flakebi February 20, 2025 12:52
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok to me, though a .replace("::llvm::", "") would improve readability.
I’ll let Nicolai decide on if he wants this or not.

@tsymalla
Copy link
Contributor Author

Sounds ok to me, though a .replace("::llvm::", "") would improve readability. I’ll let Nicolai decide on if he wants this or not.

Changed this - looks better now IMHO

Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not -- though I think there should be some Markdown-ish list formatting, i.e. something like:

/// Arguments:
///  * Value * lhs
///  * Value * rhs

@tsymalla-AMD tsymalla-AMD merged commit 726df05 into GPUOpen-Drivers:dev Mar 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants