-
Notifications
You must be signed in to change notification settings - Fork 8
Examples #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase onto main? It's quite a few commits out of date.
I tried using mkdocs build and mkdocs serve, and I couldn't click the "found here" link in usages.md:
The example files containing this code can be found here.
http://127.0.0.1:8000/usage/examples/website_usage/ returns a 404. I'm not quite sure what the intention was here, but I think mkdocs isn't happen we it.
…completely cleared by the start of the next test
Ok, I've got the rebase done (I think) and I updated the link. The link will be a 404 until you merge this into main as it links to a folder that doesn't exist in main yet. |
It looks like there are some conflicts in the test folder that I haven't messed with (probably ever). @josephmckinsey are you able to resolve those? |
It looks like the branch is still really far behind main, so that's where some of the conflicts are still. If a branch is really based off of main, then it shouldn't be possible to have a merge conflict. |
Would it make more sense for me to take my changes, delete this branch and PR, and make a new "examples" branch from main? |
Either that or play around a bit with the git rebase options like |
Update the two examples on the PyHELICS website to make them work under the latest PyHELICS.