Nonblocking v2 #102

chendo · 2015-10-26T15:30:24Z

Last one wouldn't merge cleanly with master and felt a bit meh so I started over.

Xcode feels a lot better with non-blocking turned on!

Changes:

Added checkbox in Experimental options to enable Non-blocking mode and set delay. Defaults to off and 0.1 seconds.
Uses a dispatch_source_t timer to start delay after typing
_fa_bestMatchForQuery will now bail out if the prefix changes (i.e. a new keystroke happens when it's in a middle of matching). This could be implemented a bit nicer
Matching no longer blocks main thread if non-blocking is on

Haven't been able to crash it yet!

Caveats:

Disabled inline preview for non-blocking as we see super weird reverse typing issues when the user types in a matching completion
I couldn't figure out a nice way to get dispatch_source_t into objc_setAssociatedObject (wrapping in NSValue didn't appear to do what I wanted), so it's static

…nt blocking on main thread

chendo · 2015-10-26T22:49:40Z

Forgot about the weird reverse typing thing reported by @mokagio, still a problem with inline preview turned on.

segiddins · 2015-10-27T00:33:07Z

FuzzyAutocomplete/DVTTextCompletionSession+FuzzyAutocomplete.m

@@ -22,6 +22,8 @@
 #import "FAItemScoringMethod.h"
 #import <objc/runtime.h>

+#define dispatch_on_main($block) (dispatch_get_current_queue() == dispatch_get_main_queue() ? $block() : dispatch_sync(dispatch_get_main_queue(), $block))


http://stackoverflow.com/questions/20860997/dispatch-queue-set-specific-vs-getting-the-current-queue/20862887#20862887 might dissuade you from this

We don't have any dispatch_sync calling _fa_performFuzzyFiltering from a background thread which is the only case where it would cause a deadlock, but I can work around it so we don't call dispatch_get_current_queue() cause it's deprecated

vlas-voloshin · 2015-11-06T02:21:53Z

Hey @chendo thanks for this improvement!
I got this crash today: https://dl.dropboxusercontent.com/u/40762640/Xcode_2015-11-06-131820_Vlas-Voloshin-MacBook-Pro.crash
It was in Swift code, I think I was typing default: in a switch statement. Hopefully it's helpful! I'll keep testing.

chendo · 2015-11-06T03:03:21Z

@vlas-voloshin thanks for the report, will investigate and hopefully fix! Doesn't seem to be specifically tied to the statement, more of a timing issue with running the autocompletion outside of text insertion.

vlas-voloshin · 2015-11-06T05:45:59Z

@chendo got a second crash report for you 😃
https://dl.dropboxusercontent.com/u/40762640/Xcode_2015-11-06-164437_Vlas-Voloshin-MacBook-Pro.crash

…e threads modifying priority factor cache

chendo · 2015-11-06T09:15:22Z

@vlas-voloshin thanks for that! I've pushed two commits that should hopefully solve those crashes, let me know if you see any other ones.

… weirdness

vlas-voloshin · 2015-11-06T14:29:20Z

@chendo I think it's much more stable now, thanks! Though I got another crash, now in Objective C code 😃
https://dl.dropboxusercontent.com/u/40762640/Xcode_2015-11-07-012633_Vlas-Voloshin-MacBook-Pro.crash

…n nil objects

chendo · 2015-11-07T07:25:04Z

@vlas-voloshin I've hopefully patched around that, let me know if you see that crash again

vlas-voloshin · 2015-11-08T23:20:50Z

Got you another one, @chendo! Back in Swift.
https://dl.dropboxusercontent.com/u/40762640/Xcode_2015-11-09-101908_Vlas-Voloshin-MacBook-Pro.crash

chendo · 2015-11-09T09:12:39Z

@vlas-voloshin was that with those last 2 commits I pushed?

vlas-voloshin · 2015-11-09T13:49:31Z

@chendo yes, I believe so. I will, however, try doing a clean rebuild/install of the plugin.

vlas-voloshin · 2015-11-10T00:12:32Z

@chendo I also keep seeing a rare, but annoying issue with autocompletion results list appearing and moving the caret a bit backwards while I'm still typing, so I end up inserting something inside already typed text 😢

chendo · 2015-11-10T08:06:29Z

Is that with inline preview turned on?

On 10 Nov 2015, at 11:12 AM, Vlas Voloshin [email protected] wrote:

@chendo I also keep seeing a rare, but annoying issue with autocompletion results list appearing and moving the caret a bit backwards while I'm still typing, so I end up inserting something inside already typed text

―
Reply to this email directly or view it on GitHub.

vlas-voloshin · 2015-11-10T11:32:59Z

@chendo no, I don't use Inline Preview actually.

chendo · 2015-11-11T02:44:51Z

@vlas-voloshin hmm okay, that seems like that's gonna be difficult to track down and fix especially without a reliable repro :(

cbowns · 2015-11-30T20:28:07Z

@chendo What's the best way to try this out? pull down your PR branch and build it locally? or if it makes crash symbolication easier, do you have a pre-built version I should use?

zenangst · 2016-01-21T10:04:32Z

Hey @chendo kudos on this PR, using it now to see how it spins. I'll let you know if I run into anything weird.

chendo · 2016-01-21T23:36:28Z

@cbowns yeah, pulling down the PR and building in Xcode should build it into the right directory. Don't have a pre-built version at this time.

@zenangst cool, thanks!

Also FYI, Xcode 7.3 beta has got fuzzy autocomplete but I haven't tried it out yet

zenangst · 2016-01-22T15:43:22Z

@chendo been using this all day yesterday and today at work. Works like a charm!

cbowns · 2016-01-22T20:38:08Z

Belay that, after a removal and reinstall it's all fine.

~~When I add Xcode 7.2's UUID to the compatibility list, then relaunch Xcode and load FuzzyAutocomplete, I get a crash. (Uploaded at https://cloudup.com/icgeEwpjKdW)~~

1/22/16 12:33:44.323 PM Xcode[70629]: [MT] DVTAssertions: UNCAUGHT EXCEPTION (NSInvalidArgumentException): *** -[__NSCFConstantString stringByAppendingString:]: nil argument
UserInfo: (null)
Hints: None
1/22/16 12:33:47.237 PM Xcode[70629]: [MT] DVTAssertions: 
Backtrace:
  0  0x00007fff87f56aca __exceptionPreprocess (in CoreFoundation)
  1  0x0000000108e81c67 DVTFailureHintExceptionPreprocessor (in DVTFoundation)
  2  0x00007fff95a06f7e objc_exception_throw (in libobjc.A.dylib)
  3  0x00007fff87f5698d +[NSException raise:format:] (in CoreFoundation)
  4  0x00007fff9330e027 -[NSString stringByAppendingString:] (in Foundation)
  5  0x00000001106acdf2 +[FuzzyAutocomplete createMenuItem] at /Users/cbowns/Development/FuzzyAutocompletePlugin/FuzzyAutocomplete/FuzzyAutocomplete.m:94 (in FuzzyAutocomplete)
  6  0x00000001106acc3b +[FuzzyAutocomplete menuDidChange:] at /Users/cbowns/Development/FuzzyAutocompletePlugin/FuzzyAutocomplete/FuzzyAutocomplete.m:81 (in FuzzyAutocomplete)
  7  0x00007fff87f1070c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ (in CoreFoundation)
  8  0x00007fff87f1067f ___CFXRegistrationPost_block_invoke (in CoreFoundation)
  9  0x00007fff87f0fd47 _CFXRegistrationPost (in CoreFoundation)
 10  0x00007fff87f0fab2 ___CFXNotificationPost_block_invoke (in CoreFoundation)
 11  0x00007fff87f09d42 -[_CFXNotificationRegistrar find:object:observer:enumerator:] (in CoreFoundation)
 12  0x00007fff87df8145 _CFXNotificationPost (in CoreFoundation)
 13  0x00007fff932e7921 -[NSNotificationCenter postNotificationName:object:userInfo:] (in Foundation)
 14  0x0000000108e58f55 -[NSNotificationCenter(DVTNSNotificationCenterAdditions) _dvt_postNotificationName:object:userInfo:] (in DVTFoundation)
 15  0x00007fff8b040faf -[NSMenu _menuItem:didChangeKeyEquivalentModifierMaskFrom:to:] (in AppKit)
 16  0x0000000109326fb9 -[NSMenuItem(DVTNSMenuItemAdditions) _dvt_actualKeyEquivalent] (in DVTKit)
 17  0x0000000109326e80 -[NSMenuItem(DVTNSMenuItemAdditions) dvt_setShowsKeyEquivalent:] (in DVTKit)
 18  0x000000010a0be0f1 -[IDEApplicationController _updateCloseKeyEquivalents] (in IDEKit)
 19  0x000000010a0bb11d -[IDEApplicationController applicationWillFinishLaunching:] (in IDEKit)
 20  0x00007fff87f1070c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ (in CoreFoundation)
 21  0x00007fff87f1067f ___CFXRegistrationPost_block_invoke (in CoreFoundation)
 22  0x00007fff87f0fd47 _CFXRegistrationPost (in CoreFoundation)
 23  0x00007fff87f0fab2 ___CFXNotificationPost_block_invoke (in CoreFoundation)
 24  0x00007fff87f09d42 -[_CFXNotificationRegistrar find:object:observer:enumerator:] (in CoreFoundation)
 25  0x00007fff87df8145 _CFXNotificationPost (in CoreFoundation)
 26  0x00007fff932e7921 -[NSNotificationCenter postNotificationName:object:userInfo:] (in Foundation)
 27  0x0000000108e58f55 -[NSNotificationCenter(DVTNSNotificationCenterAdditions) _dvt_postNotificationName:object:userInfo:] (in DVTFoundation)
 28  0x00007fff8b0452c2 -[NSApplication finishLaunching] (in AppKit)
 29  0x000000010945ef62 -[DVTApplication finishLaunching] (in DVTKit)
 30  0x00007fff8b044e05 -[NSApplication run] (in AppKit)
 31  0x00007fff8afc7520 NSApplicationMain (in AppKit)
 32  0x00007fff91f895ad start (in libdyld.dylib)

cbowns · 2016-01-22T20:49:18Z

Is the version number for this still 2.1.1? I'm trying to verify in the Xcode UI that I'm actually using this plug-in and not some cached thing from somewhere else in the system.

zenangst · 2016-02-01T18:26:15Z

This works great for me, haven't had a crash yet.

DenTelezhkin · 2016-02-03T09:03:17Z

Guys, what are the plans on this PR? Is it ready for use, or it's better to build plugin from nonblocking branch for now?

chendo added 6 commits October 26, 2015 23:25

Add Non-blocking mode checkbox and Filter Delay to Settings

ab1777f

First cut of non-blocking using dispatch timers

936770d

Prevent crash when table is being redrawn after a delayed filter

bf9894a

Bail out of a match if the query changes during a match

3d91aa8

Move actual filtering into a user interactive dispatch queue to preve…

2c6bcd8

…nt blocking on main thread

100ms feels a lot better

ec440b0

chendo mentioned this pull request Oct 26, 2015

WIP: Non-blocking filtering #59

Closed

1 task

chendo added 2 commits October 27, 2015 10:08

Wrap the list completion stuff in a try catch

b6070e2

Bail out if textView is nil

34961fa

segiddins reviewed Oct 27, 2015
View reviewed changes

chendo added 2 commits November 6, 2015 20:04

Wrap filtering stage in a try catch

9fc8cef

Serialise non-blocking matching to prevent double-free due to multipl…

8927f91

…e threads modifying priority factor cache

Hide inline preview before kicking off a nonblocking query to prevent…

ea27cfe

… weirdness

chendo added 2 commits November 7, 2015 18:21

It's possible for bestMatchForQuery to not complete propely and retur…

c69e3b5

…n nil objects

This should ensure that the return values are populated

07b3fc5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nonblocking v2 #102

Nonblocking v2 #102

chendo commented Oct 26, 2015

chendo commented Oct 26, 2015

segiddins Oct 27, 2015

chendo Oct 27, 2015

vlas-voloshin commented Nov 6, 2015

chendo commented Nov 6, 2015

vlas-voloshin commented Nov 6, 2015

chendo commented Nov 6, 2015

vlas-voloshin commented Nov 6, 2015

chendo commented Nov 7, 2015

vlas-voloshin commented Nov 8, 2015

chendo commented Nov 9, 2015

vlas-voloshin commented Nov 9, 2015

vlas-voloshin commented Nov 10, 2015

chendo commented Nov 10, 2015

vlas-voloshin commented Nov 10, 2015

chendo commented Nov 11, 2015

cbowns commented Nov 30, 2015

zenangst commented Jan 21, 2016

chendo commented Jan 21, 2016

zenangst commented Jan 22, 2016

cbowns commented Jan 22, 2016

cbowns commented Jan 22, 2016

zenangst commented Feb 1, 2016

DenTelezhkin commented Feb 3, 2016

Nonblocking v2 #102

Are you sure you want to change the base?

Nonblocking v2 #102

Conversation

chendo commented Oct 26, 2015

chendo commented Oct 26, 2015

segiddins Oct 27, 2015

Choose a reason for hiding this comment

chendo Oct 27, 2015

Choose a reason for hiding this comment

vlas-voloshin commented Nov 6, 2015

chendo commented Nov 6, 2015

vlas-voloshin commented Nov 6, 2015

chendo commented Nov 6, 2015

vlas-voloshin commented Nov 6, 2015

chendo commented Nov 7, 2015

vlas-voloshin commented Nov 8, 2015

chendo commented Nov 9, 2015

vlas-voloshin commented Nov 9, 2015

vlas-voloshin commented Nov 10, 2015

chendo commented Nov 10, 2015

vlas-voloshin commented Nov 10, 2015

chendo commented Nov 11, 2015

cbowns commented Nov 30, 2015

zenangst commented Jan 21, 2016

chendo commented Jan 21, 2016

zenangst commented Jan 22, 2016

cbowns commented Jan 22, 2016

cbowns commented Jan 22, 2016

zenangst commented Feb 1, 2016

DenTelezhkin commented Feb 3, 2016