feat: add expiration transaction policy
#1583
Open
+301
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hal3e
requested review from
digorithm,
MujkicA,
segfault-magnet and
Salka1988
as code owners
MujkicA
previously approved these changes
Jan 24, 2025
e2e/tests/contracts.rs
Outdated
| .calling_this_will_produce_a_block() | ||
| .with_tx_policies(TxPolicies::default().with_maturity(maturity)) | ||
| }; | ||
| let wallet = launch_provider_and_get_wallet().await?; |
There was a problem hiding this comment.
Why move away from setup_program_test?
e2e/tests/predicates.rs
Outdated
| @@ -1000,6 +1000,7 @@ async fn tx_id_not_changed_after_adding_witnesses() -> Result<()> { | |||
| tx.append_witness(witness2.into())?; | |||
| let tx_id_after_witnesses = tx.id(chain_id); | |||
|
|
|||
| provider.produce_blocks(20, None).await?; | |||
There was a problem hiding this comment.
Why the manual block generation?
There was a problem hiding this comment.
leftover from some debugging.
MujkicA
approved these changes
Feb 3, 2025
Salka1988
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1577
Release notes
Added the
expirationtransaction policy. Now the user can limit until which block height the transaction is valid.Breaking Changes
expiration: Option<u64>field toTxPoliciesstructTransactiontrait methodmaturitynow returnsOption<u64>Transactiontrait methodwith_maturityis removed.Checklist