Improve StatusBar color handling #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SandroMachado
force-pushed
the
enhancement/improve-statusbar-control
branch
from
0492021 to
b104251
Compare
|
Hey @FuYaoDe, this is a very useful PR, any plans to merge it? |
|
Hey @FuYaoDe, did you get the chance to review this PR? I'm working on top of the this fork and since I have a PR that I want to submit, I'm blocked by this one. |
|
This PR should be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
StatusBarcolor handling to not crash the component if the background color is not specified and to allow the developer to specify theStatusBarcolor for each slide.