Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Amiga protection bits and create_system #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sonnenscheinchen
Copy link

No description provided.

@FrodeSolheim
Copy link
Owner

Hi, sorry for the delay, I'll test and pull this in eventually, I just have been busy. Thanks for contributing back :)

@sonnenscheinchen
Copy link
Author

No problem, take your time and keep up your excellent work on fs-uae. :-)
Some additional info for the patch: Right now the flags are enabled only if the archive is identified as an amiga archive. Unfortunately there are many older amiga archives with header level 0 out there which can not be identified. In theory we could also get flags from these archives but the result might be wrong. Perhaps you will find a solution. ;) Documentation is here (if you don't already know): http://homepage1.nifty.com/dangan/en/Content/Program/Java/jLHA/Notes/Notes.html

I started making some extract-tools which can automatically create .uaem-files for fs-uae, but there is still a lot of work to do. Maybe some day we see something similar for fs-uae-launcher... :-)

@adamel
Copy link

adamel commented Apr 9, 2017

You should rebase your pull request branch to remove the merge commits.

0x43: 'CP/M', 0x46: 'FLEX', 0x6D: 'Macintosh', 0x52: 'Runser',
0x54: 'TownOS', 0x58: 'XOSK', 0x77: 'Windows95', 0x57: 'WindowsNT',
0x00: 'MS-DOS', 0x4A: 'Java' }
create_system = os_identifiers.get(os_identifier)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add a default value where so it does not fail when OS identifier is not recognized, e.g.:

create_system = os_identifiers.get(os_identifier, "")

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it wouldn't really fail. It would be set to None, which may be considered wrong because in fact some system has created the archive. :-) I let it set to an empty string as you suggested.

@FrodeSolheim
Copy link
Owner

This pull request has been open for an embarrassingly long time, will look over again and aim to merge and do a 0.3.0 release.

On another note, I've also set up automated builds via Github actions, so binary wheels for Windows, macOS and Linux are not created (and I upload them to pypi as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants