Skip to content

Fix CI test failures#431

Merged
ADmad merged 6 commits intomasterfrom
fix/ci-failures
Feb 19, 2026
Merged

Fix CI test failures#431
ADmad merged 6 commits intomasterfrom
fix/ci-failures

Conversation

@dereuromark
Copy link
Member

@dereuromark dereuromark commented Feb 19, 2026

Summary

  • Update command help text tests to match CakePHP 5.x output (-q flag description changed)
  • Fix InstallCommand to create WWW_ROOT before symlinking (prevents "No such file or directory" error)
  • Remove outdated popper.js references from tests (Bootstrap 5.3+ bundles Popper)
  • Simplify testInstallVerbose to check key messages instead of exact file list output

CI Status

  • PHP 8.4 & 8.5 highest: ✅ All tests pass
  • PHP 8.2 highest: Tests pass, but CI fails due to --fail-on-all-issues and a pre-existing BreadcrumbsHelper deprecation (not related to this PR)
  • PHP 8.2 lowest: Shared workflow passes PHPUnit 11/12 options to PHPUnit 10 (workflow issue)
  • cs-stan: Phive installation issues in shared workflow (workflow issue)

The actual test code is working correctly - the CI failures are due to shared workflow configuration issues that need to be addressed separately.

- Update command help text tests to match CakePHP 5.x output
  (quiet flag description changed to include "non-interactive mode")

- Fix InstallCommand to create WWW_ROOT before symlinking
  (PluginAssetsSymlinkCommand fails if parent directory doesn't exist)

- Remove outdated popper.js references from tests
  (Bootstrap 5.3+ bundles Popper into bootstrap.bundle.js)

- Simplify testInstallVerbose to check key messages instead of exact output
  (File list changes with each bootstrap release, making exact checks brittle)
@dereuromark
Copy link
Member Author

Remaining CI issues (shared workflow problems)

1. PHP 8.2 lowest - PHPUnit version mismatch

Location: ADmad/.github/.github/workflows/testsuite-without-db.yml

The workflow passes PHPUnit 11/12 CLI options to PHPUnit 10:

vendor/bin/phpunit --display-phpunit-notices --display-phpunit-deprecations ...

These flags don't exist in PHPUnit 10 (Unknown option "--display-phpunit-notices").

Fix: Conditionally use different flags based on PHPUnit version, or only use flags common to all supported versions.


2. PHP 8.2 highest - Deprecation fails CI

Location: ADmad/.github/.github/workflows/testsuite-without-db.yml

Uses --fail-on-all-issues which fails on deprecations. The BreadcrumbsHelper has a pre-existing deprecation warning (using add() with array instead of addMany()).

Fix options:

  • Fix the BreadcrumbsHelper deprecation in bootstrap-ui
  • Or adjust the workflow to not fail on framework deprecation warnings

3. cs-stan - Phive installation fails

Location: cakephp/.github/.github/workflows/cs-stan.yml

Phive requires TTY confirmation to import GPG keys:

Import this key? [y|N]
[ERROR] Needs tty to be able to confirm

Fix: Use phive install --trust-gpg-keys <fingerprints> with the appropriate key fingerprints for phpstan and psalm.

@dereuromark dereuromark requested a review from ADmad February 19, 2026 15:56
@dereuromark
Copy link
Member Author

cc @ADmad - the first two issues are in your shared workflow repo

@ADmad
Copy link
Member

ADmad commented Feb 19, 2026

the first two issues are in your shared workflow repo

Just need to change phpunit 10's constraint to from ^10.5.5 to ^10.5.58 to fix that.

@dereuromark
Copy link
Member Author

The ^10.5.58 constraint doesn't help here - --display-phpunit-notices doesn't exist in PHPUnit 10.x at all, it was introduced in PHPUnit 11.

The shared workflow runs:

vendor/bin/phpunit --display-phpunit-notices --display-phpunit-deprecations ...

These flags don't exist in PHPUnit 10. The workflow would need to detect the PHPUnit version and use different flags, or only use flags that exist in all supported versions.

@ADmad ADmad closed this Feb 19, 2026
@ADmad ADmad reopened this Feb 19, 2026
@ADmad
Copy link
Member

ADmad commented Feb 19, 2026

I have fixed my workflow as well as Cake's to resolve the phive issue.

@ADmad ADmad merged commit 731d71a into master Feb 19, 2026
5 checks passed
@ADmad ADmad deleted the fix/ci-failures branch February 19, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants