Conversation
- Update command help text tests to match CakePHP 5.x output (quiet flag description changed to include "non-interactive mode") - Fix InstallCommand to create WWW_ROOT before symlinking (PluginAssetsSymlinkCommand fails if parent directory doesn't exist) - Remove outdated popper.js references from tests (Bootstrap 5.3+ bundles Popper into bootstrap.bundle.js) - Simplify testInstallVerbose to check key messages instead of exact output (File list changes with each bootstrap release, making exact checks brittle)
Remaining CI issues (shared workflow problems)1. PHP 8.2 lowest - PHPUnit version mismatchLocation: The workflow passes PHPUnit 11/12 CLI options to PHPUnit 10: vendor/bin/phpunit --display-phpunit-notices --display-phpunit-deprecations ...These flags don't exist in PHPUnit 10 ( Fix: Conditionally use different flags based on PHPUnit version, or only use flags common to all supported versions. 2. PHP 8.2 highest - Deprecation fails CILocation: Uses Fix options:
3. cs-stan - Phive installation failsLocation: Phive requires TTY confirmation to import GPG keys: Fix: Use |
|
cc @ADmad - the first two issues are in your shared workflow repo |
Just need to change phpunit 10's constraint to from |
|
The The shared workflow runs: vendor/bin/phpunit --display-phpunit-notices --display-phpunit-deprecations ...These flags don't exist in PHPUnit 10. The workflow would need to detect the PHPUnit version and use different flags, or only use flags that exist in all supported versions. |
|
I have fixed my workflow as well as Cake's to resolve the phive issue. |
1cf0829 to
4ee4983
Compare
4ee4983 to
71bb10e
Compare
Summary
-qflag description changed)InstallCommandto createWWW_ROOTbefore symlinking (prevents "No such file or directory" error)testInstallVerboseto check key messages instead of exact file list outputCI Status
--fail-on-all-issuesand a pre-existingBreadcrumbsHelperdeprecation (not related to this PR)The actual test code is working correctly - the CI failures are due to shared workflow configuration issues that need to be addressed separately.