* Ability to provide custom dtd to serializer

FriendsOfCXML · Jan 28, 2025 · ff5103a · ff5103a
1 parent 6855c48
commit ff5103a
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/CXml/Serializer.php b/src/CXml/Serializer.php
@@ -30,11 +30,13 @@
 {
     public const DOC_TYPE_VERSION = '1.2.063';
 
-    private function __construct(private SerializerInterface $jmsSerializer)
-    {
-    }
+    private function __construct(
+        private SerializerInterface $jmsSerializer,
+        private string $dtdUri
+    )
+    {}
 
-    public static function create(): self
+    public static function create(string $dtdUri = 'http://xml.cxml.org/schemas/cXML/' . self::DOC_TYPE_VERSION . '/cXML.dtd'): self
     {
         $jmsSerializer = SerializerBuilder::create()
             ->configureListeners(static function (EventDispatcherInterface $dispatcher): void {
@@ -55,7 +57,7 @@ public static function create(): self
             )
             ->build();
 
-        return new self($jmsSerializer);
+        return new self($jmsSerializer, $dtdUri);
     }
 
     public function deserialize(string $xml): CXml
@@ -71,11 +73,11 @@ public function deserialize(string $xml): CXml
         return $this->jmsSerializer->deserialize($xml, CXml::class, 'xml');
     }
 
-    public function serialize(CXml $cxml, string $docTypeVersion = self::DOC_TYPE_VERSION): string
+    public function serialize(CXml $cxml): string
     {
         $xml = $this->jmsSerializer->serialize($cxml, 'xml');
 
-        $docType = '<!DOCTYPE cXML SYSTEM "http://xml.cxml.org/schemas/cXML/' . $docTypeVersion . '/cXML.dtd">';
+        $docType = '<!DOCTYPE cXML SYSTEM "'.$this->dtdUri.'">'."\n";
         $xmlPrefix = '<?xml version="1.0" encoding="UTF-8"?>';
 
         // add doctype, as it is mandatory in cXML