Update guidelines based on recent discussions within CQWG #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use C++20, there is no need to tell people about C++11.
for more information, see https://pre-commit.ci
chennes
reviewed
Apr 25, 2025
| @@ -194,13 +230,29 @@ In this document the **bolded** text will indicate how important each suggestion | |||
|
|
|||
|
|
|||
| ## Naming Things | |||
|
|
|||
| Naming described in that section of the document refers mostly to newer parts of code. Some modules use different naming conventions, | |||
| while checking the code Reviewer should take into account surrounding code and first of all ensure consistency within the closes scope. | |||
There was a problem hiding this comment.
Suggested change
| while checking the code Reviewer should take into account surrounding code and first of all ensure consistency within the closes scope. | |
| while checking the code Reviewer should take into account surrounding code and first of all ensure consistency within the closest scope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates guidelines based on our recent discussions within CQWG. The aim is to provide more unified review experience for both reviewers and PR authors. PR is split into commits so if we don't want some part of the PR we can remove some parts, or discuss them as separate PRs.
Important Changes
autoto reviewers guideautoguidelinesstd::initialize_listover array as it does not require explicit count