Skip to content

Add special handling for MeshPart #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 1 commit into from
Feb 10, 2026
Merged

Add special handling for MeshPart #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Addon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,13 @@ def import_from_addon(self, repo: Addon, all_repos: List[Addon]):
# Plot might fail for a number of reasons
self.wbs.append(dep)
fci.Console.PrintLog("Failed to import Plot module\n")
elif dep.lower() == "meshpart":
# MeshPart is strange: it doesn't ever appear in the listWorkbenches() output
try:
__import__("MeshPart")
except ImportError:
self.wbs.append(dep)
fci.Console.PrintLog("Failed to import MeshPart module\n")
Comment on lines +760 to +766
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new MeshPart special-case changes dependency detection behavior but isn’t covered by existing unit tests. Please add a test for MissingDependencies.import_from_addon that exercises both paths (MeshPart import succeeds -> not added to missing wbs; MeshPart import fails -> added and log emitted), using the existing FreeCADGui/Console mocking approach in AddonManagerTest.

Copilot uses AI. Check for mistakes.
else:
self.wbs.append(dep)

Expand Down
Loading