Skip to content

Migrate to new constraints location #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 1 commit into from
Feb 10, 2026
Merged

Migrate to new constraints location #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addonmanager_preferences_defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"last_fetched_macro_cache_hash": "Cache never fetched, no hash available",
"macro_cache_url": "https://addons.freecad.org/macro_cache.zip",
"old_backup_handling": "ask",
"pip_constraints_path": "https://raw.githubusercontent.com/FreeCAD/FreeCAD-addons/refs/heads/master/constraints/",
"pip_constraints_path": "https://raw.githubusercontent.com/FreeCAD/Addons/refs/heads/main/Data/Python/",
"proxy_settings_migrated_2025": false,
"proxy_type": "system",
"proxy_host": "none",
Expand Down
6 changes: 3 additions & 3 deletions addonmanager_utilities.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,15 +632,15 @@ def create_pip_call(args: List[str]) -> List[str]:
parsed_url = urlparse(constraints)
major = sys.version_info.major
minor = sys.version_info.minor
expected_filename = f"constraints-py{major}{minor}.txt"
expected_rel_path = f"{major}.{minor}/constraints.txt"
if parsed_url.scheme == "https":
Comment on lines 633 to 636
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected_filename now contains a path segment (e.g. 3.11/constraints.txt), not just a filename. Consider renaming it (e.g. constraints_rel_path) to avoid confusion and make it clearer that a directory component is included.

Copilot uses AI. Check for mistakes.
# The only supported remote scheme is https, and this is the default setup
if not constraints.endswith("/"):
constraints += "/"
constraints += expected_filename
constraints += expected_rel_path
else:
# If it wasn't https, treat it like it's a local path
constraints = os.path.join(constraints, expected_filename)
constraints = os.path.join(constraints, expected_rel_path.replace("/", os.path.sep))
args.extend(["--constraint", constraints])

call_args.extend(args)
Expand Down
Loading