Skip to content

External wb error cleanup#342

Merged
chennes merged 1 commit intoFreeCAD:devfrom
chennes:externalWBErrorCleanup
Feb 10, 2026
Merged

External wb error cleanup#342
chennes merged 1 commit intoFreeCAD:devfrom
chennes:externalWBErrorCleanup

Conversation

@chennes
Copy link
Member

@chennes chennes commented Feb 9, 2026

Add MeshPart to the recognized list, and correct formatting of the error message.

Copilot AI review requested due to automatic review settings February 9, 2026 20:39
@chennes chennes force-pushed the externalWBErrorCleanup branch from 06d4e27 to 909f901 Compare February 9, 2026 20:40
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Addon Manager’s internal workbench dependency handling and warning output, and bumps the package metadata version/date.

Changes:

  • Add MeshPart to the recognized internal workbench dependency list.
  • Adjust the “Unrecognized internal workbench” warning formatting to include a trailing newline.
  • Update package.xml version/date for the dev build.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

File Description
package.xml Bumps addon version/date metadata.
Addon.py Extends internal workbench mapping and tweaks warning message formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 405 to 407
"AddonsInstaller",
"{}: Unrecognized internal workbench '{}'",
"{}: Unrecognized internal workbench '{}'\n",
).format(self.name, dep.package)
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the trailing newline inside the translatable string changes the translation key (msgid) and will drop existing translations for this warning. Prefer keeping the msgid unchanged and append the newline outside translate(...).format(...) when calling PrintWarning.

Copilot uses AI. Check for mistakes.
"import": "Import",
"material": "Material",
"mesh": "Mesh",
"meshpart": "MeshPart",
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new INTERNAL_WORKBENCHES entry will break the unit test test_internal_workbench_list, which loads depends_on_all_workbenches.xml and asserts that it contains every internal workbench. Please update that XML fixture (or relax the assertion) to include a MeshPart dependency so CI remains green.

Copilot uses AI. Check for mistakes.
@chennes chennes force-pushed the externalWBErrorCleanup branch from 909f901 to d99424c Compare February 9, 2026 22:32
@chennes chennes merged commit 1723bcf into FreeCAD:dev Feb 10, 2026
11 checks passed
@chennes chennes deleted the externalWBErrorCleanup branch February 10, 2026 00:51
@chennes chennes added the release to main Trigger an Action to create a PR backporting to `main` label Feb 10, 2026
@github-actions
Copy link

Successfully created backport PR for main:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release to main Trigger an Action to create a PR backporting to `main`

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant