Skip to content

[Backport main] Translate freecadweb to freecad in macro icon path #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chennes merged 1 commit into from
Feb 9, 2026
Merged

[Backport main] Translate freecadweb to freecad in macro icon path #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion MacroCacheCreator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ def fetch_macros(self):
self.retrieve_macros_from_wiki()
print("Downloading icons...")
for macro in self.macros.values():
self.get_icon(macro)
try:
self.get_icon(macro)
except RuntimeError as e:
self.macro_errors[macro.name] = str(e)
self.macro_stats["errors"] = len(self.macro_errors)

def create_cache(self) -> str:
Expand Down Expand Up @@ -163,6 +166,8 @@ def get_icon(macro: Macro):
"""Downloads the macro's icon from whatever source is specified and stores its binary
contents in self.icon_data"""
if macro.icon.startswith("http://") or macro.icon.startswith("https://"):
if "freecadweb" in macro.icon:
macro.icon = macro.icon.replace("freecadweb", "freecad")
parsed_url = urllib.parse.urlparse(macro.icon)
try:
p = requests.get(macro.icon, headers=headers, timeout=10.0)
Expand Down